-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/longhorn replicas #648
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, if you've sufficiently tested that the new behavior is as you expect
I tested it by deploying a cluster, creating a PV and
I can run some additional tests if you would like @MarioUhrik |
The tests you've done sound sufficient Miro, LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
had a look, looks great, had some questions/suggestions.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGMT!
…audie into feat/longhorn-replicas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff, LGTM, thanks @MiroslavRepka! 🚀
This PR fixes #564 by implementing the algorithm, run upon node deletion, which tries to create a new replica for the longhorn volume, if any replicas will be lost due to node deletion.
It also fixes a small bug, when deleting master nodes (case when the API endpoint was not defined).
An additional feature is the introduction of variadic functions for the
kubectl
package.