-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Log rework #657
Log rework #657
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job with the PR. I left few comments, some of them are regarding the log linguistic correctness
😅 - but I think this can be a completly separate task, I will leave the decision to you. Others are about log level in some point that I'm not sure about. Once again awesome job! 😄
…into feat/rework-logs
…into feat/rework-logs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
This PR implements a feature described in #622. It also clarifies/adds some additional logs, as in the
info
level, a lot of information is no longer visible.Moreover, in the
debug
level, thekubectl
logs are now visible, with cluster ID prefix.Example:
closes #622