Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log rework #657

Merged
merged 25 commits into from
Mar 24, 2023
Merged

Log rework #657

merged 25 commits into from
Mar 24, 2023

Conversation

MiroslavRepka
Copy link
Contributor

This PR implements a feature described in #622. It also clarifies/adds some additional logs, as in the info level, a lot of information is no longer visible.

Moreover, in the debug level, the kubectl logs are now visible, with cluster ID prefix.
Example:

2:48PM INF services/kuber/server/server.go:60 > Setting up the longhorn on the cluster miro-cluster-s87luix module=kuber
miro-cluster-s87luix     namespace/longhorn-system created
miro-cluster-s87luix     podsecuritypolicy.policy/longhorn-psp created
miro-cluster-s87luix     serviceaccount/longhorn-service-account created
miro-cluster-s87luix     configmap/longhorn-default-setting created
miro-cluster-s87luix     configmap/longhorn-storageclass created

closes #622

@MiroslavRepka MiroslavRepka self-assigned this Mar 23, 2023
@MiroslavRepka MiroslavRepka added feature New feature go Pull requests that update Go code labels Mar 23, 2023
Copy link
Contributor

@cloudziu cloudziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job with the PR. I left few comments, some of them are regarding the log linguistic correctness 😅 - but I think this can be a completly separate task, I will leave the decision to you. Others are about log level in some point that I'm not sure about. Once again awesome job! 😄

services/builder/configProcessor.go Outdated Show resolved Hide resolved
services/builder/configProcessor.go Show resolved Hide resolved
services/builder/serviceCaller.go Show resolved Hide resolved
services/kuber/server/longhorn/longhorn.go Show resolved Hide resolved
services/kuber/server/nodes/nodes.go Outdated Show resolved Hide resolved
services/kuber/server/nodes/nodes.go Outdated Show resolved Hide resolved
Copy link
Contributor

@cloudziu cloudziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@MiroslavRepka MiroslavRepka added this pull request to the merge queue Mar 24, 2023
Merged via the queue into master with commit 58111bc Mar 24, 2023
@MiroslavRepka MiroslavRepka deleted the feat/rework-logs branch March 24, 2023 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Supress logs from tools other than Claudie in info level, but show them in debug level.
2 participants