Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix retries in Wireguard playbook #658

Merged
merged 4 commits into from
Mar 24, 2023
Merged

Fix retries in Wireguard playbook #658

merged 4 commits into from
Mar 24, 2023

Conversation

MiroslavRepka
Copy link
Contributor

Fixes #646

Verified by running a simple input manifest.
Logs from Ansibler:

VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     PLAY [nodes] *******************************************************************
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     TASK [Wait 300 seconds for target connection to become reachable/usable] *******
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-1]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-3]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-2]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-2]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-1]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-3]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     TASK [Gather facts from nodes] *************************************************
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-2]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-1]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-compute-3]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-3]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-1]
VPN - services/ansibler/server/clusters/miro-cluster-hvwkuvd     ok: [gcp-control-2]

After this, the playbook ran as normal without any unnecessary retries.

@MiroslavRepka MiroslavRepka added the bug Something isn't working label Mar 24, 2023
@MiroslavRepka MiroslavRepka self-assigned this Mar 24, 2023
cloudziu
cloudziu approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@cloudziu cloudziu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple as that 😄 LGFM 👍

@MiroslavRepka MiroslavRepka marked this pull request as ready for review March 24, 2023 18:38
@MiroslavRepka MiroslavRepka added this pull request to the merge queue Mar 24, 2023
Merged via the queue into master with commit fe13680 Mar 24, 2023
@MiroslavRepka MiroslavRepka deleted the feat/gather-facts-manually branch March 24, 2023 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cloudziu cloudziu cloudziu approved these changes

@MarioUhrik MarioUhrik MarioUhrik approved these changes

Assignees

@MiroslavRepka MiroslavRepka

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug: Gather facts manually before runnig playbook
3 participants
@MiroslavRepka @cloudziu @MarioUhrik