Feat/refactor probes #691
Merged
Feat/refactor probes #691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroslavRepka
added
enhancement
MiroslavRepka
requested review from
Archisman-Mridha,
MarioUhrik and
wULLSnpAXbWZGYDYyhWTKKspEQoaYxXyhoisqHf
MiroslavRepka
force-pushed
the
feat/refactor-probes
branch
from
caf05eb
to
9545377
Compare
MarioUhrik
approved these changes
Apr 5, 2023
Archisman-Mridha
approved these changes
Apr 5, 2023
MarioUhrik
approved these changes
Apr 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency on
grpc-health-probein favour of Kubernetes native grpc health probes.Each gRPC server in Claudie now defines two services
<service name>-liveness-> liveness health probe<service name>-readiness-> readiness health probe