Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add secret-validation controller, Update README.md #821

Merged
merged 16 commits into from
May 30, 2023
Merged

Add secret-validation controller, Update README.md #821

merged 16 commits into from
May 30, 2023

Conversation

cloudziu
Copy link
Contributor

PR for #683

MarioUhrik
MarioUhrik suggested changes May 29, 2023
View reviewed changes
Copy link
Contributor

@MarioUhrik MarioUhrik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks quite fine in general :)

README.md Outdated Show resolved Hide resolved
MiroslavRepka
MiroslavRepka reviewed May 29, 2023
View reviewed changes
Copy link
Contributor

@MiroslavRepka MiroslavRepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice job @cloudziu, I left some minor comments.

README.md Show resolved Hide resolved
services/frontend/adapters/inbound/controller.go Outdated Show resolved Hide resolved
services/frontend/adapters/inbound/controller.go Outdated Show resolved Hide resolved
services/frontend/adapters/inbound/secret_watcher.go Outdated Show resolved Hide resolved
services/frontend/adapters/inbound/controller.go Outdated Show resolved Hide resolved
services/frontend/adapters/inbound/controller_validator.go Outdated Show resolved Hide resolved
services/frontend/adapters/inbound/controller_validator.go Outdated Show resolved Hide resolved
MiroslavRepka
MiroslavRepka approved these changes May 30, 2023
View reviewed changes
Copy link
Contributor

@MiroslavRepka MiroslavRepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, great work @cloudziu!

services/frontend/domain/usecases/controller_validator.go Outdated Show resolved Hide resolved
@cloudziu cloudziu requested a review from MarioUhrik May 30, 2023 09:07
@cloudziu cloudziu marked this pull request as ready for review May 30, 2023 09:24
@cloudziu cloudziu linked an issue May 30, 2023 that may be closed by this pull request
Feature: validate secret on create #683
Closed
@cloudziu cloudziu added this pull request to the merge queue May 30, 2023
Merged via the queue into master with commit 5f0f757 May 30, 2023
1 check was pending
@cloudziu cloudziu deleted the feature/secret-validation-controller branch May 30, 2023 16:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiroslavRepka MiroslavRepka MiroslavRepka approved these changes

@MarioUhrik MarioUhrik MarioUhrik approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feature: validate secret on create
3 participants
@cloudziu @MiroslavRepka @MarioUhrik