-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/manifest as crd #872
Conversation
…d DS instead of Status fields
…manifest.go, extend REQUEUE_IN_PROGRES
I don't like this much, but I understand this is the best way. |
Will the status of the inputManifest be updated by events and errors? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work thus far 👍
…t type, Target PR comments, Edit testing-framework that it adapts inputmanifest type
Yes, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work @cloudziu!
This PR implements partially #357 and resolves #787.
The Frontend service has been redone to instead of using secret files as Claudie manifests, now it use CRD.
List of changes that will change UX:
labels
on the InputManifest/Secret resourcekubectl apply
level. The workflow will be similar to Kubernetes Pods scenario. If a Pod referencing a non-existing secret will be created - it will CrashLoop in an error state, Claudie will generate an error and check again in 60s. (Interval of REQUEUE_AFTER_ERROR const var).v1beta1.claudie.io/finalizer
read moreToDo:
inputmanifest
type.