Fix/grpc keepalive #903
Merged
Fix/grpc keepalive #903
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MiroslavRepka
approved these changes
Jun 26, 2023
|
Had to also adjust the server settings as otherwise the server would just sent
Most values are the same as the defaults, which can be found https://grpc.io/docs/guides/keepalive/#keepalive-configuration-specification The only changes are in and |
cloudziu
approved these changes
Jun 26, 2023
MiroslavRepka
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #885
by setting the keepalive params for a client connection and adding a retry policy on RPC that fail due to code
unavailableUnavailable indicates the service is currently unavailableThe client will try for roughly ~10 minutes for the service to become available and retry the RPC, given that our calls are idempotent this shouldn't be an issues.
It may happen that two calls at the same time will be executed (the one previosly started where the connection was lost and the new one), however. In terraformer we use a lock so that shouldn't be an issues and with the rest of the calls it shouldn't raise any negative side effects.