Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/rename frontend service #939

Merged
merged 11 commits into from
Jul 10, 2023
Merged

Feature/rename frontend service #939

merged 11 commits into from
Jul 10, 2023

Conversation

cloudziu
Copy link
Contributor

@cloudziu cloudziu commented Jul 6, 2023

Closes #870

@cloudziu cloudziu self-assigned this Jul 6, 2023
@MarioUhrik
Copy link
Contributor

Well done Adam, I am quite happy about this :)

@katapultcloud
Copy link
Contributor

LGTM, good work 👍

MiroslavRepka
MiroslavRepka approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@MiroslavRepka MiroslavRepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, once merged, please remember to remove the frontend registry in GHCR.

@cloudziu
Copy link
Contributor Author

cloudziu commented Jul 6, 2023 •
edited

once merged, please remember to remove the frontend registry in GHCR.

@MiroslavRepka are you sure? That would prevent deploying from older tags.

@MiroslavRepka
Copy link
Contributor

You are right @cloudziu let's open an issue to discontinue that registry some time later.

@cloudziu cloudziu marked this pull request as ready for review July 10, 2023 06:50
MiroslavRepka
MiroslavRepka approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@MiroslavRepka MiroslavRepka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work on those diagrams @cloudziu

.github/workflows/CI-pipeline.yml Outdated Show resolved Hide resolved
katapultcloud
katapultcloud approved these changes Jul 10, 2023
View reviewed changes
Copy link
Contributor

@katapultcloud katapultcloud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM nice work!

@MiroslavRepka MiroslavRepka mentioned this pull request Jul 10, 2023
Merged
@cloudziu cloudziu added this pull request to the merge queue Jul 10, 2023
Merged via the queue into master with commit a35523c Jul 10, 2023
1 check passed
@cloudziu cloudziu deleted the feature/rename-frontend-service branch July 10, 2023 11:24
@cloudziu cloudziu mentioned this pull request Jul 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MiroslavRepka MiroslavRepka MiroslavRepka approved these changes

@katapultcloud katapultcloud katapultcloud approved these changes

Assignees

@cloudziu cloudziu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Chore: Rename the Frontend service
4 participants
@cloudziu @MarioUhrik @katapultcloud @MiroslavRepka