chore(plugin-stealth): Mitigate other occurences of Chromium bug (#130)

berstend · Jan 7, 2020 · 0b976f1 · 0b976f1
1 parent 6cd17ff
commit 0b976f1
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 7 deletions.
diff --git a/packages/puppeteer-extra-plugin-stealth/evasions/media.codecs/index.js b/packages/puppeteer-extra-plugin-stealth/evasions/media.codecs/index.js
@@ -48,6 +48,10 @@ class Plugin extends PuppeteerExtraPlugin {
         const canPlayType = {
           // Make toString() native
           get(target, key) {
+            // Mitigate Chromium bug (#130)
+            if (typeof target[key] === 'function') {
+              return target[key].bind(target)
+            }
             return Reflect.get(target, key)
           },
           // Intercept certain requests

diff --git a/packages/puppeteer-extra-plugin-stealth/evasions/webgl.vendor/index.js b/packages/puppeteer-extra-plugin-stealth/evasions/webgl.vendor/index.js
@@ -29,14 +29,11 @@ class Plugin extends PuppeteerExtraPlugin {
 
         const getParameterProxyHandler = {
           get(target, key) {
-            // There's a slight difference in toString: Our version does not return a named function by default
-            if (key === 'toString') {
-              const dummyFn = function toString() {
-                return target.toString() // `function getParameter() { [native code] }`
-              }.bind(Function.prototype.toString) // eslint-disable-line
-              return dummyFn
-            }
             try {
+              // Mitigate Chromium bug (#130)
+              if (typeof target[key] === 'function') {
+                return target[key].bind(target)
+              }
               return Reflect.get(target, key)
             } catch (err) {
               err.stack = stripErrorStack(err.stack)