Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use process.once and re-emit the kill signal after cleanup work is complete #519

Closed
wants to merge 1 commit into from
Closed

Use process.once and re-emit the kill signal after cleanup work is complete #519

wants to merge 1 commit into from

Conversation

Androbin
Copy link

@Androbin Androbin commented Jun 20, 2021 •
edited

Fixes #467
Co-authored-by: @Tyler-Murphy #467 (comment)
/cc @brunogaspar

@Androbin @Tyler-Murphy
Use process.once and re-emit the kill signal after cleanup work is …
009f1db 
…complete

Co-authored-by: Tyler Murphy <tjames7000@gmail.com>
@github-actions github-actions bot added the package: core Affecting a core package label Jun 20, 2021
@Androbin Androbin mentioned this pull request Jun 20, 2021
Closed
@Niek
Copy link
Collaborator

Niek commented Aug 9, 2021

Isn't #530 the better approach?

@berstend
Copy link
Owner

Closing in favor of #530

@berstend berstend closed this Sep 23, 2021
@Androbin Androbin deleted the signals branch September 23, 2021 17:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
package: core Affecting a core package
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Electron process becomes unresponsive to SIGINT
3 participants
@Androbin @Niek @berstend