Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard against multiple calls to Logger, Webserver #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

wandernauta
Copy link
Contributor

The configuration parser allows something like this:

Webserver{address="192.0.2.10:8080", user="api-access-for-robot", password="robot"}
Webserver{address="192.0.2.20:8090", user="dashboard-for-human", password="human"}

But the behavior is potentially unexpected:

  • For Logger: the "last one wins".
  • For Webserver: "both win" (you indeed get two endpoints) except that the username and password for both endpoints are taken from the last call.

This makes it so that any second call to Webserver or Logger is rejected.

Before this change, the behavior was:

- For Logger: the "last one wins"
- For Webserver: "both win" except that the username and password for both endpoints are taken from the last call

This makes it so that any second call to Webserver or Logger is rejected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant