Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Output styles don't end with semi-colon #4

Open
dougahall opened this issue Jul 13, 2017 · 4 comments
Open

Output styles don't end with semi-colon #4

dougahall opened this issue Jul 13, 2017 · 4 comments

Comments

@dougahall
Copy link

dougahall commented Jul 13, 2017

Here's an example output:

h2{
    padding-top: 10px
    background: blue 
}

There should be a semi-colon delimiter between the styles (and optionally after the last style):

h2{
    padding-top: 10px;
    background: blue 
}
@dougahall
Copy link
Author

Hi @bertjohnson,
This project was a great time-saver and we appreciate your work! We just ran into these two issues that I've submitted. I have fixes for both if you are open to pull requests.

Thanks,
Doug

@joyously
Copy link

The semicolon is a delimiter, not a terminator. So having no semicolon on the last statement is valid CSS.

@dougahall
Copy link
Author

Ah, good point @joyously. The delimiter is not being placed into the output either. I've updated the example in the issue. Thanks!

@crutchcorn
Copy link

crutchcorn commented Jul 13, 2017

Why not add options for either @joyously?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants