Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

asset-pipeline doesn't handle plugins resources #33

Closed
fedotxxl opened this issue Sep 29, 2013 · 4 comments
Closed

asset-pipeline doesn't handle plugins resources #33

fedotxxl opened this issue Sep 29, 2013 · 4 comments

Comments

@fedotxxl
Copy link
Contributor

For plugins resources Grails generates /js/..., /css/... urls but asset-pipeline doesn't process them.

Adding
"/css/$id**" (controller: 'assets', action: 'index') "/js/$id**" (controller: 'assets', action: 'index')
fixed this problem. May be this is not the best solution but it works... I think this is a bug

@davydotcom
Copy link
Contributor

This is not a bug webapp is intended to be used for unprocessed entities. We do support the webapp folders for plugins but only for the /assets path. It is the intent that new apps using asset pipeline no longer use the webapp folder as this webapp folder is copied into war files automatically bypassing any post processing you may want down the line. This is why the assets folder is preferred

Sent from my iPhone

On Sep 29, 2013, at 3:29 PM, fedotxxl notifications@github.com wrote:

For plugins resources Grails generates /js/..., /css/... urls but asset-pipeline doesn't processes them.

Adding
"/css/$id**" (controller: 'assets', action: 'index')
"/js/$id**" (controller: 'assets', action: 'index')
fixed this problem. May be this is not the best solution but it works... I think this is a bug


Reply to this email directly or view it on GitHub.

@fedotxxl
Copy link
Contributor Author

There are still plugins that doesn't use asset plugin. Currently you break their work. I think you can add this moment to documentation to clarify it

@davydotcom
Copy link
Contributor

I don't break legacy plugin support at all web all plugin integration still works as normally would if asset pipeline was not installed

Sent from my iPhone

On Sep 29, 2013, at 3:54 PM, fedotxxl notifications@github.com wrote:

There are still plugins that doesn't use asset plugin. Currently you break their work. I think you can add this moment to documentation to clarify it


Reply to this email directly or view it on GitHub.

@davydotcom
Copy link
Contributor

Gonna close this as this isn't quite correct. If you would like to provide a specific example I'd be happy to run through it with you and show you why this isnt the case or vice versa. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants