Added Puppeteer & Custom Chrome Profile support out the box #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… array of cookie objects and enabled this as a value to be passed as a 'format'. 2) moved process.platform checks inside of getCookies due to the fact this crashes on require('chrome-cookies-secure') if a Default Chrome Browser profile is unavailable. 3) Added the ability to pass through a new 'Profile' argument, specifying which Chrome profile one wishes to use for testing. This is passed to getCookies as the last argument, after the callback function. If no arg is passed, 'Default' is set.
… This has been tested in live for a number of weeks
|
*This has been tested in a live app for the last month, using a custom Chrome profile, Puppeteer & Chrome Canary. |
|
Thanks for making these changes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new passable variable to getCookies - 'Puppeteer' - that allows one to retrieve cookies ready to load directly into Puppeteer without any additional formatting.
Added new variable to getCookies - 'Profile' - that allows one to select the Chrome Profile cookies they'd like to use / load. If none is given, the 'Default' Chrome Profile will be used.
Moved the root OS (& Chrome profile) detection to the point the 'getCookies' function is called, rather than when the module is initially loaded in NODEJS. The reason being it will crash an application if no 'Default' profile for Chrome exists (which the module previously assumed) and in my case wasn't present.