Added an awaitable Promise wrapper for getCookies #21
Conversation
rubengmurray
changed the title
|
Note Node comes with an implementation of that wrapper, as I show in https://stackoverflow.com/a/65265955/3001761 |
Thanks for updating this PR with the link @textbook - I believe that wrapper will solve all cases except for where Still, given this PR has been hanging around for 9 months, I'm sure your answer will help many. |
|
Now this PR has been about a year |
Yeah this is no longer maintained by the owner unfortunately. |
|
Yeah, noticed that as well. I found your PR merged in at https://github.com/paragbaxi/chrome-cookies-secure, FTR. |
|
Had no idea about that fork. Cheers |
|
☺ Looking to get this in Playwright.
…On Mon, Mar 22, 2021, 5:35 PM Reece Daniels ***@***.***> wrote:
Had no idea about that fork. Cheers
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#21 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHJD4MCXYAIWXIK6CPJKELTE6Z3JANCNFSM4LRJIHFA>
.
|
|
Need any assistance? I'm pretty invested in this package and still use it everyday. Hadn't heard of |
|
Hi, sorry for the radio silence here - don't have a lot of great excuses but let's just say toddler + COVID has made me less attentive to my repos than I'd like to be. @rubengmurray would you be interested in taking this module over if you have the bandwidth for it? |
|
self/family first! i added you @rubengmurray as a contributor |
|
Yeah I'd be happy to assist with this going forward as a maintainer. What's the best way to get the latest code changes on the existing npm package? It would be good for continuity if existing package users could benefit from updates and we can have a look through the open PRs here. Can we merge |
|
@rubengmurray @paragbaxi Can you give me your npm usernames and I can add you as maintainers there and here and you can take it from there? Thanks. |
Same username on npm, |
paragbaxi |
Makes sense. |
|
@rubengmurray @paragbaxi Invites sent, please merge/modify in whatever way you see fit. Thanks! Let me know if there's anything else you need. |
|
@paragbaxi it looks like your version is just this repo with:
Perhaps it's just easier to merge these two PRs in here rather than merge repos or your |
|
@paragbaxi are you happy to merge / approve this in? I'm wary of doing it myself given it's my own work. |
|
My bad for the delay. Excited to see movement here. Yeah I can do it. |
|
noticed the line break. any style we're following? i prefer prettier default |
Prettier default is good with me 👍 good suggestion Perhaps a separate PR with Prettier config applied to the entire repo is in order? |
No description provided.