Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(protocol): add berty protocol proto #1385

Merged
merged 6 commits into from Sep 27, 2019
Merged

feat(protocol): add berty protocol proto #1385

merged 6 commits into from Sep 27, 2019

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Sep 25, 2019 •
edited by moul-bot

Protocol frist draft, based on #1375

@gfanton gfanton requested a review from a team as a code owner September 25, 2019 20:03
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
@weekly-digest weekly-digest bot mentioned this pull request Sep 26, 2019
Closed
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 26, 2019 •
edited

Codecov Report

Merging #1385 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1385   +/-   ##
=======================================
  Coverage   67.85%   67.85%           
=======================================
  Files           2        2           
  Lines          56       56           
=======================================
  Hits           38       38           
  Misses         16       16           
  Partials        2        2

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90cbf07...0eceeb6. Read the comment docs.

@moul moul mentioned this pull request Sep 26, 2019
Merged
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
moul
moul reviewed Sep 26, 2019
View reviewed changes
api/bertyprotocol.proto Outdated Show resolved Hide resolved
aeddi
aeddi approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@aeddi aeddi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LVGTM 👍 🥇 💯

@moul moul merged commit ca84e31 into berty:master Sep 27, 2019
@moul moul deleted the dev/gfanton/protocol branch September 27, 2019 10:36
@weekly-digest weekly-digest bot mentioned this pull request Oct 3, 2019
Closed
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glouvigny glouvigny glouvigny left review comments

@moul moul moul approved these changes

@aeddi aeddi aeddi approved these changes

Assignees

@moul moul

@glouvigny glouvigny

@aeddi aeddi

@gfanton gfanton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@gfanton @moul @glouvigny @aeddi