Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: event-sourcing compliant berty protocol #1556

Merged
merged 1 commit into from Dec 20, 2019

Conversation

glouvigny
Copy link
Member

No description provided.

@glouvigny glouvigny force-pushed the glouvigny/protocol-draft branch 3 times, most recently from a6e3127 to 7abe692 Compare December 20, 2019 11:49
@codecov
Copy link

codecov bot commented Dec 20, 2019

Codecov Report

Merging #1556 into master will increase coverage by 2.88%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1556      +/-   ##
==========================================
+ Coverage      63%   65.89%   +2.88%     
==========================================
  Files          31       28       -3     
  Lines        1184      950     -234     
==========================================
- Hits          746      626     -120     
+ Misses        310      218      -92     
+ Partials      128      106      -22
Impacted Files Coverage Δ
go/pkg/bertyprotocol/api_device.go 0% <0%> (ø)
go/pkg/bertyprotocol/api_group.go 0% <0%> (ø) ⬆️
go/pkg/bertyprotocol/api_event.go 0% <0%> (ø) ⬆️
go/pkg/bertyprotocol/api_contact.go 0% <0%> (ø) ⬆️
go/pkg/bertyprotocol/api_contactrequest.go 0% <0%> (ø) ⬆️
go/pkg/bertyprotocol/api_app.go 0% <0%> (ø)
go/framework/bpbridge/bridge.go 59.45% <0%> (-6.76%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b0d1e3...da9507f. Read the comment docs.

api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Show resolved Hide resolved
api/bertyprotocol.proto Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
api/bertyprotocol.proto Outdated Show resolved Hide resolved
Copy link
Member

@90dy 90dy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything that seems important is ok for me so LGTM since we resolve ci conflicts 👍

@moul
Copy link
Member

moul commented Dec 20, 2019

let's make smaller changes on new PRs

thank you everyone

@moul moul merged commit ea25a0e into berty:master Dec 20, 2019
@moul moul deleted the glouvigny/protocol-draft branch December 20, 2019 17:38
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants