Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Update to go 1.13 #1557

Merged
merged 21 commits into from Dec 20, 2019
Merged

feat: Update to go 1.13 #1557

merged 21 commits into from Dec 20, 2019

Conversation

gfanton
Copy link
Member

@gfanton gfanton commented Dec 19, 2019

No description provided.

@gfanton gfanton requested review from moul and a team as code owners December 19, 2019 17:16
@trafico-bot trafico-bot bot added the 🚧 WIP label Dec 19, 2019
@gfanton gfanton self-assigned this Dec 19, 2019
@codecov
Copy link

codecov bot commented Dec 20, 2019 •
edited

Codecov Report

Merging #1557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #1557   +/-   ##
======================================
  Coverage      63%     63%           
======================================
  Files          31      31           
  Lines        1184    1184           
======================================
  Hits          746     746           
  Misses        310     310           
  Partials      128     128
Impacted Files Coverage Δ
go/framework/bpbridge/bridge.go 66.21% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5753167...e13a01e. Read the comment docs.

@gfanton gfanton changed the title WIP: Update to go 1.13 feat: Update to go 1.13 Dec 20, 2019
@gfanton gfanton changed the title feat: Update to go 1.13 WIP: Update to go 1.13 Dec 20, 2019
@gfanton gfanton changed the title WIP: Update to go 1.13 feat: Update to go 1.13 Dec 20, 2019
moul
moul reviewed Dec 20, 2019
View reviewed changes
go/Makefile Show resolved Hide resolved
moul
moul reviewed Dec 20, 2019
View reviewed changes
go/cmd/berty/main.go Outdated Show resolved Hide resolved
moul
moul reviewed Dec 20, 2019
View reviewed changes
go/config.bzl Show resolved Hide resolved
moul
moul approved these changes Dec 20, 2019
View reviewed changes
Copy link
Member

@moul moul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@moul moul merged commit 3b0d1e3 into berty:master Dec 20, 2019
@moul moul deleted the feat/go-1.13 branch December 20, 2019 13:14
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@weekly-digest weekly-digest bot mentioned this pull request Dec 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moul moul moul approved these changes

Assignees

@gfanton gfanton

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gfanton @moul @n0izn0iz