Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Berty QR: Long user names affect position of QR code #4391

Closed
1 task done
peletron opened this issue Aug 29, 2022 · 3 comments · Fixed by #4741
Closed
1 task done

Berty QR: Long user names affect position of QR code #4391

peletron opened this issue Aug 29, 2022 · 3 comments · Fixed by #4741
Labels
bug type: something isn't working p/android PR/Issue related to Android p/ios PR/Issue related to iOS verified Bug is verified

Comments

@peletron
Copy link
Collaborator

peletron commented Aug 29, 2022 •
edited by moul-bot

Is there an existing issue for this?

  • I have searched the existing issues

Berty product

Mobile app

Berty product version

2.431.1

OS

iOS

OS version

iOS 15.6.1

Device

iPhone 13 Pro Max

Steps to reproduce

  1. Navigate to the Berty app
  2. Make sure user has some long name
  3. Click on the + Icon do add contact

Current behavior

Long name affect position of Berty QR code. Code is shifted little bit to the left.

image

Expected behavior

Berty QR code should be always placed in the middle of white layout.

Other

No response
@peletron peletron added bug type: something isn't working p/android PR/Issue related to Android p/ios PR/Issue related to iOS labels Aug 29, 2022
@peletron peletron self-assigned this Aug 29, 2022
@peletron peletron changed the title Berty QA: Long user names affect position of QA code Berty QR: Long user names affect position of QR code Aug 29, 2022
@jefft0 jefft0 added the verified Bug is verified label May 10, 2023
@jefft0
Copy link
Collaborator

jefft0 commented Jun 30, 2023

@iuricmp will make a PR to use an ellipsis for long display names in the QR screen and other placed.

@jefft0
Copy link
Collaborator

jefft0 commented Aug 4, 2023

@iuricmp wrote the code for the change. Will make a PR.

@iuricmp iuricmp mentioned this issue Aug 6, 2023
Merged
iuricmp added a commit that referenced this issue Aug 6, 2023
@iuricmp
fix: Long user names affect position of QR code
641fcca 
Long user names affect position of QR code

Signed-off-by: Iuri Pereira <iuricmp@gmail.com>

fix #4391
@github-actions
Copy link

github-actions bot commented Aug 7, 2023

🎉 This issue has been resolved in version 2.469.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug type: something isn't working p/android PR/Issue related to Android p/ios PR/Issue related to iOS verified Bug is verified
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: Long user names affect position of QR code berty/berty
2 participants
@jefft0 @peletron