Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: network config peer cache & mdns discover #1149

Merged
merged 3 commits into from Mar 21, 2019
Merged

fix: network config peer cache & mdns discover #1149

merged 3 commits into from Mar 21, 2019

Conversation

90dy
Copy link
Member

@90dy 90dy commented Mar 21, 2019

No description provided.

@90dy 90dy added this to the w19.12 ⚰️ milestone Mar 21, 2019
@90dy 90dy self-assigned this Mar 21, 2019
@90dy 90dy requested a review from a team as a code owner March 21, 2019 10:07
@90dy
fix(rn): network config peer cache
035866e 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
gfanton
gfanton approved these changes Mar 21, 2019
View reviewed changes
Copy link
Member

@gfanton gfanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@90dy
chore(core): remove unnecessary logs
f5ab88b 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@codecov
Copy link

codecov bot commented Mar 21, 2019 •
edited

Codecov Report

Merging #1149 into master will increase coverage by 0.08%.
The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1149      +/-   ##
==========================================
+ Coverage   26.69%   26.77%   +0.08%     
==========================================
  Files          79       79              
  Lines        5676     5680       +4     
==========================================
+ Hits         1515     1521       +6     
+ Misses       3936     3930       -6     
- Partials      225      229       +4
Impacted Files Coverage Δ
core/node/network.go 61.11% <ø> (-2.05%) ⬇️
core/network/host/discovery.go 0% <0%> (ø) ⬆️
core/network/driver.go 52.38% <0%> (-1.39%) ⬇️
core/network/network.go 53.48% <100%> (+1.1%) ⬆️
core/network/cache.go 85.71% <0%> (-3.58%) ⬇️
core/crypto/enclave/generic_keystore.go 42.22% <0%> (+10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b38bb62...13bc646. Read the comment docs.

@90dy
fix(network): mdns discovery
13bc646 
Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy 90dy changed the title fix(rn): network config peer cache fix: network config peer cache & mdns discover Mar 21, 2019
@90dy 90dy merged commit d7ee578 into berty:master Mar 21, 2019
@90dy 90dy deleted the fix-rn-netconf-peercache branch March 21, 2019 11:57
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfanton gfanton gfanton approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
w19.12 ⚰️
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@90dy @gfanton