Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: refactor logger #2270

Merged
merged 2 commits into from Sep 6, 2020
Merged

feat: refactor logger #2270

merged 2 commits into from Sep 6, 2020

Conversation

moul
Copy link
Member

@moul moul commented Sep 2, 2020

  • new go/internal/logutil library
  • configure namespaces (protocol, messenger, ipfs, libp2p, orbitdb, gorm, ...)
  • refactor go/cmd/berty
  • refactor go/cmd/rdvp
  • refactor go/internal/testutil
  • update tool/*
  • update */Makefile
  • update READMEs
  • update .buildkite and .github/workflows
  • update docker-compose.yml files
  • refactor go/framework/bertybridge
  • adapt react-native code
  • fix libp2p proxy or refactor the ipfs/lib-p2p logger (depends on Configure a custom zap logger ipfs/go-log#102) -> it's currently disabled by default and can be enabled with an env var

@trafico-bot trafico-bot bot added the 🚧 WIP label Sep 2, 2020
@moul moul self-assigned this Sep 2, 2020
@moul-bot moul-bot force-pushed the dev/moul/refactor-logger branch 2 times, most recently from 46762cb to 3eb1289 Compare September 4, 2020 20:24
@n0izn0iz n0izn0iz force-pushed the dev/moul/refactor-logger branch 2 times, most recently from faf9d37 to 13dc0ee Compare September 6, 2020 14:12
@n0izn0iz n0izn0iz changed the title WIP feat: refactor logger feat: refactor logger Sep 6, 2020
@n0izn0iz n0izn0iz marked this pull request as ready for review September 6, 2020 14:17
@n0izn0iz n0izn0iz requested review from a team as code owners September 6, 2020 14:17
@n0izn0iz n0izn0iz marked this pull request as draft September 6, 2020 14:21
@codecov
Copy link

codecov bot commented Sep 6, 2020

Codecov Report

Merging #2270 into master will decrease coverage by 0.62%.
The diff coverage is 23.15%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2270      +/-   ##
==========================================
- Coverage   43.38%   42.75%   -0.63%     
==========================================
  Files          65       66       +1     
  Lines        6793     6914     +121     
==========================================
+ Hits         2947     2956       +9     
- Misses       3283     3388     +105     
- Partials      563      570       +7     
Flag Coverage Δ
#unittests 42.75% <23.15%> (-0.63%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/framework/bertybridge/driver_logger.go 0.00% <0.00%> (ø)
go/framework/bertybridge/bridge_protocol.go 35.73% <8.33%> (+0.61%) ⬆️
go/internal/logutil/logutil.go 24.34% <24.34%> (ø)
go/pkg/bertymessenger/service.go 47.40% <50.00%> (-4.09%) ⬇️
go/framework/bertybridge/bridge.go 68.00% <100.00%> (ø)
go/pkg/bertymessenger/testing.go 15.26% <100.00%> (ø)
go/pkg/bertyprotocol/service.go 80.48% <100.00%> (+0.24%) ⬆️
go/pkg/bertyprotocol/testing.go 86.25% <100.00%> (ø)
go/pkg/bertymessenger/db.go 20.27% <0.00%> (-6.76%) ⬇️
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a62e964...458e87e. Read the comment docs.

moul and others added 2 commits September 6, 2020 19:15
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
Signed-off-by: Norman Meier <norman@berty.tech>
Signed-off-by: Manfred Touron <94029+moul@users.noreply.github.com>
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

Expected release notes (by @moul-bot)

features:
refactor logger (0300150)

others (will not be included in Semantic-Release notes):
support new logger filters on mobile (458e87e)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@moul moul marked this pull request as ready for review September 6, 2020 17:23
@moul moul merged commit 0a2f644 into master Sep 6, 2020
@moul moul deleted the dev/moul/refactor-logger branch September 6, 2020 17:41
@github-actions
Copy link

github-actions bot commented Sep 6, 2020

🎉 This PR is included in version 2.132.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants