Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP feat: push #2988

Closed
wants to merge 1 commit into from
Closed

WIP feat: push #2988

wants to merge 1 commit into from

Conversation

glouvigny
Copy link
Member

No description provided.

@glouvigny glouvigny self-assigned this Jan 7, 2021
@glouvigny glouvigny requested review from moul and a team as code owners January 7, 2021 12:56
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #2988 (b767ef9) into master (201c7bb) will decrease coverage by 0.09%.
The diff coverage is 30.43%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2988      +/-   ##
==========================================
- Coverage   29.10%   29.01%   -0.10%     
==========================================
  Files         328      336       +8     
  Lines       20066    20977     +911     
  Branches     1446     1453       +7     
==========================================
+ Hits         5841     6087     +246     
- Misses      13156    13744     +588     
- Partials     1069     1146      +77     
Flag Coverage Δ
go.unittests 35.25% <32.09%> (-0.39%) ⬇️
js.unittests 11.97% <8.21%> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
go/cmd/berty/main.go 67.39% <ø> (ø)
go/internal/initutil/manager.go 65.25% <ø> (ø)
go/internal/initutil/notification.go 25.92% <0.00%> (-5.90%) ⬇️
go/pkg/bertyprotocol/api_contactrequest.go 40.81% <0.00%> (+3.31%) ⬆️
go/pkg/bertyprotocol/api_multimember.go 4.34% <0.00%> (+4.34%) ⬆️
go/pkg/bertyprotocol/events.go 61.03% <ø> (ø)
go/pkg/bertyprotocol/services_push_apns.go 0.00% <0.00%> (ø)
go/pkg/bertyprotocol/services_push_fcm.go 0.00% <0.00%> (ø)
go/pkg/protocoltypes/events_account.go 0.00% <0.00%> (ø)
js/packages/api/root.pb.js 100.00% <ø> (ø)
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 201c7bb...51004b5. Read the comment docs.

@glouvigny glouvigny force-pushed the glouvigny/push branch 2 times, most recently from 66892ca to f53fcc6 Compare January 14, 2021 13:25
@moul moul marked this pull request as draft January 19, 2021 15:37
@glouvigny glouvigny force-pushed the glouvigny/push branch 7 times, most recently from 6035550 to b767ef9 Compare January 22, 2021 13:45
Signed-off-by: Guillaume Louvigny <glouvigny@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants