Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: android footer and status bar #3302

Merged
merged 1 commit into from May 12, 2021

Conversation

clegirar
Copy link
Contributor

@clegirar clegirar commented May 3, 2021

Fix #3300 #3301

Signed-off-by: clegirar clemntgirard@gmail.com

@clegirar clegirar requested a review from a team as a code owner May 3, 2021 11:39
@clegirar clegirar self-assigned this May 3, 2021
@auto-add-label auto-add-label bot added the bug type: something isn't working label May 3, 2021
@clegirar clegirar linked an issue May 3, 2021 that may be closed by this pull request
@codecov
Copy link

codecov bot commented May 3, 2021

Codecov Report

Merging #3302 (e8006ac) into master (7925402) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3302      +/-   ##
==========================================
- Coverage   29.07%   29.07%   -0.01%     
==========================================
  Files         354      354              
  Lines       22030    22031       +1     
  Branches     1702     1702              
==========================================
  Hits         6405     6405              
- Misses      14472    14473       +1     
  Partials     1153     1153              
Flag Coverage Δ
js.unittests 10.94% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
js/packages/components/chat/ContactSettings.tsx 17.14% <0.00%> (ø)
js/packages/components/chat/OneToOneSettings.tsx 14.28% <0.00%> (ø)
js/packages/components/chat/common.tsx 6.47% <0.00%> (-0.04%) ⬇️
js/packages/components/main/Scan.tsx 13.46% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7925402...e8006ac. Read the comment docs.

@clegirar clegirar force-pushed the fix/android-footer-and-status-bar branch from 9ac3951 to 9e75304 Compare May 3, 2021 13:17
@clegirar clegirar requested a review from moul as a code owner May 3, 2021 13:17
@clegirar clegirar force-pushed the fix/android-footer-and-status-bar branch 3 times, most recently from 943affc to 28854dc Compare May 6, 2021 08:44
Signed-off-by: clegirar <clemntgirard@gmail.com>
@clegirar clegirar force-pushed the fix/android-footer-and-status-bar branch from 28854dc to e8006ac Compare May 6, 2021 10:40
@clegirar clegirar merged commit 075a066 into berty:master May 12, 2021
@clegirar clegirar deleted the fix/android-footer-and-status-bar branch May 12, 2021 13:34
@github-actions
Copy link

🎉 This PR is included in version 2.284.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug type: something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Android text input conv not center Android status bar color on some screens
1 participant