fix(mobile): patch gomobile build import #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moul
reviewed
Oct 15, 2018
| @@ -12,7 +12,7 @@ RUN go get golang.org/x/mobile/cmd/gomobile | |||
|
|
|||
| RUN sdkmanager ndk-bundle | |||
|
|
|||
| COPY ./gomobile-env-flag.diff /tmp/gomobile-env-flag.diff | |||
| COPY ../../client/react-native/patch/gomobile-env-flag.diff /tmp/gomobile-env-flag.diff | |||
There was a problem hiding this comment.
you should not COPY/ADD files from parent folders in Dockerfiles
glouvigny
force-pushed
the
glouvigny/fix-patch-gomobile
branch
from
eb05102
to
9ff0a88
Compare
glouvigny
force-pushed
the
glouvigny/fix-patch-gomobile
branch
from
9ff0a88
to
2500960
Compare
glouvigny
force-pushed
the
glouvigny/fix-patch-gomobile
branch
from
2500960
to
18ce28e
Compare
moul
added a commit
that referenced
this pull request
Nov 21, 2018
fix(mobile): patch gomobile build import
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.