Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: long usernames exceeds the username box #4647

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

iuricmp
Copy link
Contributor

@iuricmp iuricmp commented Mar 29, 2023

  • make the username box flexible to fit long names

Screenshot_20230329_152438_Berty Debug

  • also fit short names

Screenshot_20230329_152414_Berty Debug

@iuricmp iuricmp requested a review from a team as a code owner March 29, 2023 14:30
@iuricmp iuricmp linked an issue Mar 29, 2023 that may be closed by this pull request
1 task
@iuricmp iuricmp requested a review from clegirar March 29, 2023 14:33
@iuricmp iuricmp self-assigned this Mar 29, 2023
@D4ryl00
Copy link
Contributor

D4ryl00 commented Mar 29, 2023

Have you set a size limit for the username box?
What happens if your username is 1000 characters long?

@iuricmp iuricmp force-pushed the 4642-long-usernames-go-out-of-the-user-name-box branch from 7d418e0 to c965ee8 Compare April 19, 2023 04:57
@iuricmp iuricmp force-pushed the 4642-long-usernames-go-out-of-the-user-name-box branch from c965ee8 to 7768fd5 Compare April 19, 2023 05:47
@iuricmp
Copy link
Contributor Author

iuricmp commented Apr 19, 2023

Have you set a size limit for the username box? What happens if your username is 1000 characters long?

Yes. The string will be truncated on the tail if exceeds the 2nd line. Docs Reference.

@iuricmp iuricmp force-pushed the 4642-long-usernames-go-out-of-the-user-name-box branch 4 times, most recently from cfdf075 to ff662ec Compare April 19, 2023 08:12
@codecov
Copy link

codecov bot commented Apr 19, 2023

Codecov Report

Patch coverage: 66.66% and project coverage change: -0.18 ⚠️

Comparison is base (3c04bec) 31.62% compared to head (ff662ec) 31.44%.

❗ Current head ff662ec differs from pull request most recent head 2106ce5. Consider uploading reports for the commit 2106ce5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4647      +/-   ##
==========================================
- Coverage   31.62%   31.44%   -0.18%     
==========================================
  Files         446      442       -4     
  Lines       22981    22974       -7     
  Branches     1866     1870       +4     
==========================================
- Hits         7267     7224      -43     
- Misses      15163    15203      +40     
+ Partials      551      547       -4     
Flag Coverage Δ
js.unittests 43.73% <66.66%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ges/screens/settings/SettingsHome/SettingsHome.tsx 42.96% <66.66%> (+0.44%) ⬆️

... and 22 files with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@iuricmp iuricmp force-pushed the 4642-long-usernames-go-out-of-the-user-name-box branch from ff662ec to e0dd918 Compare April 19, 2023 11:35
Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
@iuricmp iuricmp force-pushed the 4642-long-usernames-go-out-of-the-user-name-box branch from e0dd918 to 2106ce5 Compare April 19, 2023 11:36
@github-actions
Copy link

github-actions bot commented Apr 19, 2023

Expected release notes (by @iuricmp)

fixes:
long usernames exceeds the username box (2106ce5)

  • I hereby acknowledge these release notes are 🥙 AWESOME 🥙

@iuricmp iuricmp requested a review from clegirar April 19, 2023 12:00
Copy link
Contributor

@clegirar clegirar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@iuricmp iuricmp merged commit 3bbea45 into master Apr 19, 2023
@iuricmp iuricmp deleted the 4642-long-usernames-go-out-of-the-user-name-box branch April 19, 2023 12:50
@github-actions
Copy link

🎉 This PR is included in version 2.465.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long usernames go out of the user name box
3 participants