-
Notifications
You must be signed in to change notification settings - Fork 378
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: long usernames exceeds the username box #4647
fix: long usernames exceeds the username box #4647
Conversation
iuricmp
commented
Mar 29, 2023
•
edited
Loading
edited
- make the username box flexible to fit long names
- also fit short names
Have you set a size limit for the username box? |
7d418e0
to
c965ee8
Compare
c965ee8
to
7768fd5
Compare
Yes. The string will be truncated on the tail if exceeds the 2nd line. Docs Reference. |
cfdf075
to
ff662ec
Compare
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## master #4647 +/- ##
==========================================
- Coverage 31.62% 31.44% -0.18%
==========================================
Files 446 442 -4
Lines 22981 22974 -7
Branches 1866 1870 +4
==========================================
- Hits 7267 7224 -43
- Misses 15163 15203 +40
+ Partials 551 547 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 22 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
ff662ec
to
e0dd918
Compare
Signed-off-by: Iuri Pereira <iuricmp@gmail.com>
e0dd918
to
2106ce5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
🎉 This PR is included in version 2.465.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |