feat: update kubo to v0.19 #4655
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
a012fde
to
d86a456
Compare
jefft0
reviewed
Apr 17, 2023
go/cmd/rdvp/main.go
Outdated
| libp2p_relayv1.WithResources(ressources), | ||
| // libp2p_relayv1.WithACL(acl)), // not use for now | ||
| _, err = libp2p_relayv2.New(host, | ||
| // disable limits for now to have an equivalent off a relay v1 |
jefft0
reviewed
Apr 17, 2023
gfanton
force-pushed
the
feat/update-kubo-19
branch
4 times, most recently
from
20d9730
to
890f95c
Compare
gfanton
force-pushed
the
feat/update-kubo-19
branch
4 times, most recently
from
96e28fc
to
29c6bcf
Compare
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #4655 +/- ##
==========================================
- Coverage 31.55% 31.54% -0.01%
==========================================
Files 436 436
Lines 22859 22854 -5
Branches 1842 1842
==========================================
- Hits 7213 7210 -3
+ Misses 15106 15104 -2
Partials 540 540
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
29c6bcf
to
b72ff91
Compare
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
b72ff91
to
f7db392
Compare
gfanton
force-pushed
the
feat/update-kubo-19
branch
5 times, most recently
from
6e70f9b
to
e260a62
Compare
D4ryl00
approved these changes
Apr 20, 2023
go/internal/initutil/ipfs.go
Outdated
| @@ -589,8 +589,8 @@ func (m *Manager) setupIPFSConfig(cfg *ipfs_cfg.Config) ([]libp2p.Option, error) | |||
| // enable mdns | |||
| cfg.Discovery.MDNS.Enabled = false | |||
|
|
|||
| // disable managed auto relay | |||
| cfg.Swarm.RelayClient.Enabled = ipfs_cfg.False | |||
| // make sure auto relay is enable | |||
There was a problem hiding this comment.
Why do you change autorelay to true?
There was a problem hiding this comment.
that's a typo error, thanks !
go/internal/initutil/ipfs.go
Outdated
| @@ -620,8 +617,8 @@ func (m *Manager) setupIPFSConfig(cfg *ipfs_cfg.Config) ([]libp2p.Option, error) | |||
|
|
|||
| // @NOTE(gfanton): disable quic transport so we can init a custom transport | |||
| // with reusport disable | |||
| cfg.Swarm.Transports.Network.QUIC = ipfs_cfg.False | |||
| p2popts = append(p2popts, libp2p.Transport(quict.NewTransport, quict.DisableReuseport())) | |||
| cfg.Swarm.Transports.Network.QUIC = ipfs_cfg.True | |||
There was a problem hiding this comment.
Is it ok the enable QUIC? Is reusePort disabled?
There was a problem hiding this comment.
that was a mistake, thanks !
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
e260a62
to
2755548
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
2755548
to
88a4cf1
Compare
Signed-off-by: gfanton <8671905+gfanton@users.noreply.github.com>
gfanton
force-pushed
the
feat/update-kubo-19
branch
from
88a4cf1
to
ddde847
Compare
|
🎉 This PR is included in version 2.466.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update kubo to v0.19.0
depends on: