Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(push): handle envelopes from node #914

Merged
merged 1 commit into from
Jan 21, 2019
Merged

feat(push): handle envelopes from node #914

merged 1 commit into from
Jan 21, 2019

Conversation

90dy
Copy link
Member

@90dy 90dy commented Jan 18, 2019

fix #912

@90dy 90dy requested a review from a team as a code owner January 18, 2019 13:05
@90dy 90dy self-assigned this Jan 18, 2019
@90dy 90dy added this to the w19.03 🔔 milestone Jan 18, 2019
@codecov
Copy link

codecov bot commented Jan 18, 2019 •
edited

Codecov Report

Merging #914 into master will decrease coverage by 0.18%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #914      +/-   ##
==========================================
- Coverage   22.73%   22.55%   -0.19%     
==========================================
  Files          65       65              
  Lines        4477     4514      +37     
==========================================
  Hits         1018     1018              
- Misses       3272     3309      +37     
  Partials      187      187
Impacted Files Coverage Δ
core/node/push.go 0% <0%> (ø) ⬆️
core/manager/account/account.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff0d0ad...33cb5c1. Read the comment docs.

@90dy 90dy changed the title feat(node): open envelopes feat(push): handle envelopes from node Jan 18, 2019
@90dy
feat(push): handle envelopes from node
33cb5c1 
fix #912

Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
glouvigny
glouvigny approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@glouvigny glouvigny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine

@90dy 90dy merged commit eef6664 into berty:master Jan 21, 2019
@90dy 90dy deleted the feat-912 branch January 21, 2019 10:57
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glouvigny glouvigny glouvigny approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
w19.03 🔔
Development

Successfully merging this pull request may close these issues.

Push - Node - Open envelopes
2 participants
@90dy @glouvigny