Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(node): token randomly change when provide it in chan #919

Merged
merged 1 commit into from Jan 21, 2019
Merged

fix(node): token randomly change when provide it in chan #919

merged 1 commit into from Jan 21, 2019

Conversation

90dy
Copy link
Member

@90dy 90dy commented Jan 21, 2019

No description provided.

@90dy 90dy added this to the w19.04 ☃️ milestone Jan 21, 2019
@90dy 90dy self-assigned this Jan 21, 2019
@90dy 90dy requested a review from a team as a code owner January 21, 2019 10:58
@codecov
Copy link

codecov bot commented Jan 21, 2019

Codecov Report

Merging #919 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #919      +/-   ##
==========================================
- Coverage   22.55%   22.53%   -0.02%     
==========================================
  Files          65       65              
  Lines        4514     4518       +4     
==========================================
  Hits         1018     1018              
- Misses       3309     3313       +4     
  Partials      187      187
Impacted Files Coverage Δ
core/node/push.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e681d5c...a65c253. Read the comment docs.

@alexsland alexsland modified the milestone: w19.04 ☃️ Jan 21, 2019
Token randomly change when provite it in subscribers chans because of native garbage collector

fix #916

Signed-off-by: Godefroy Ponsinet <godefroy.ponsinet@outlook.com>
@90dy 90dy merged commit da2f732 into berty:master Jan 21, 2019
@90dy 90dy deleted the fix-916 branch February 5, 2019 18:10
@github-actions
Copy link

🎉 This PR is included in version 1.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants