Handle cases where build list in a buildBlock is incomplete

[ekelen]

Assumes are sorted by build.created_at. If limit=1 is passed as a query param and the first build has a merge request that is associated with 20 builds, API will still only return that first build.

Best solution is probably just to make a second API call with merge request ID as a parameter for the last (oldest) unique MR ID in the initial build list response.

[ekelen]

Not forgotten. Note to self, I will need some kind of flag to indicate second request has been made but I would rather not further pollute global state.

[moul]

Is this issue still relevant, or can we close it?

[ekelen]

Depends if you think it's a bad experience (I do) to ask for buildlist with "limit=10" and if you get two blocks (two merge requests) in your result, with one block potentially containing incomplete list of builds.

Is there a (planned) route to get a mergerequest list? This would make this less messy to handle, but can still be done on the front.

[moul]

do you need just the list of mergerequests or do you need the builds and artifacts, but grouped by mergerequests?

[ekelen]

Given the way we use it now, the easiest to implement on front is probably build list grouped by merge request (plus the idea of a "build list" is central, after all).

If possible, an extra field in server response with 'n_builds' for the MR would be helpful, so the front can tell user if the MR block has more builds than requested.

• /build-list?grouped_by=mergerequest&limit=25 --> if builds[25th] is the first of 3 builds for that MR, front needs to hear that from server somehow.