feat(front): allow filtering from ui by project #218
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
trafico-bot
bot
added
the
🚧 WIP
ekelen
force-pushed
the
feat/web-add-default-project-filters
branch
2 times, most recently
from
3920d98
to
9004059
Compare
ekelen
changed the title
trafico-bot
bot
added
🔍 Ready for Review
get project filter from driver and artifact kind remove branch from state and hardcode cleanup branch display in modal add toggler for filtering by project add style for disabled filters in modal enable add and remove of projects in filter ui setup binding between driver, artifact kinds, and project build_drivers->build_driver to match api add chat build driver to default url params remove debug text apply filters from ui remove duplicates from filters organize imports in filter modal parse url query for drivers add default query if user unselects all filters reset build drivers when not searching by project add APK to gomobile project filter defaults
ekelen
force-pushed
the
feat/web-add-default-project-filters
branch
from
9004059
to
cf01800
Compare
moul
approved these changes
May 13, 2020
trafico-bot
bot
added
✅ Approved
trafico-bot
bot
added
✨ Merged
|
🎉 This PR is included in version 2.42.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
?artifact_kinds=2&artifact_kinds=1&build_driver=3?artifact_kinds=1&build_driver=1Style tweaks:
Blocks #202
Closes #201