Skip to content

Commit

Permalink
[KYUUBI apache#1806] Fix LaunchEngine may be closed multiple times
Browse files Browse the repository at this point in the history
<!--
Thanks for sending a pull request!

Here are some tips for you:
  1. If this is your first time, please read our contributor guidelines: https://kyuubi.readthedocs.io/en/latest/community/contributions.html
  2. If the PR is related to an issue in https://github.com/apache/incubator-kyuubi/issues, add '[KYUUBI #XXXX]' in your PR title, e.g., '[KYUUBI #XXXX] Your PR title ...'.
  3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][KYUUBI #XXXX] Your PR title ...'.
-->

### _Why are the changes needed?_
<!--
Please clarify why the changes are needed. For instance,
  1. If you add a feature, you can talk about the use case of it.
  2. If you fix a bug, you can clarify why it is a bug.
-->

close apache#1806

### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible

- [ ] Add screenshots for manual tests if appropriate

- [ ] [Run test](https://kyuubi.readthedocs.io/en/latest/develop_tools/testing.html#running-tests) locally before make a pull request

Closes apache#1807 from cfmcgrady/kyuubi-1806.

Closes apache#1806

c70a594 [Fu Chen] fix

Authored-by: Fu Chen <cfmcgrady@gmail.com>
Signed-off-by: Kent Yao <yao@apache.org>
  • Loading branch information
cfmcgrady authored and yaooqinn committed Jan 20, 2022
1 parent 555dfac commit 5bc7ea1
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -126,7 +126,9 @@ class KyuubiSessionImpl(
}

override def close(): Unit = {
closeOperation(launchEngineOp.getHandle)
if (!launchEngineOp.isTimedOut) {
closeOperation(launchEngineOp.getHandle)
}
super.close()
sessionManager.credentialsManager.removeSessionCredentialsEpoch(handle.identifier.toString)
try {
Expand Down

0 comments on commit 5bc7ea1

Please sign in to comment.