Add configurable position #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beryu
requested changes
Mar 11, 2018
| @@ -182,17 +188,26 @@ public class CustomizableActionSheet: NSObject { | |||
| } | |||
| } | |||
| } | |||
| let positionX: CGFloat = 0 | |||
| let positionY: CGFloat! | |||
| let moveY: CGFloat! | |||
There was a problem hiding this comment.
Do not use ! .
Please set default value.
| @@ -212,7 +227,12 @@ public class CustomizableActionSheet: NSObject { | |||
|
|
|||
| // Hide animation | |||
| self.maskView.alpha = 1 | |||
| let moveY = targetView.bounds.height - self.itemContainerView.frame.origin.y | |||
| let moveY: CGFloat! | |||
There was a problem hiding this comment.
! is not necessary in here.
Please remove it.
|
Thanks for your comments! The changes have been made in 778952b -- please let me know if you'd like the commits squashed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the option to have the action sheet drop down from the top.
Thanks for the great lib!