add support for multiple states. #2
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* modify tests to fit the multistate case. * regenerate dist/ The used classList API only allows `add()` being called with a single class. Therefore if your data-bespoke-state attribute contains multiple classes, it throws an exception. When might this happen? For example when you are having transitions isolated into own classes, so we can swap them between slides.
markdalgleish
added a commit
that referenced
this pull request
May 4, 2013
Add support for multiple states.
|
Thanks! :) |
|
As always my pleasure, sir! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The used classList API only allows
add()being called with a singleclass. Therefore if your data-bespoke-state attribute contains multiple
classes, it throws an exception.
When might this happen? For example when you are having transitions
isolated into own classes, so we can swap them between slides.