This repository has been archived by the owner on Feb 22, 2023. It is now read-only.
Bst dev server deploy configuration #422
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Changes Unknown when pulling faac69c on bstDevServer into ** on master**. |
jkelvie
suggested changes
Dec 21, 2017
circle.yml
Outdated
| tag: /bst-dev-.*/ | ||
| commands: | ||
| - docker login -e $DOCKER_EMAIL -u $DOCKER_USER -p $DOCKER_PASS | ||
| - docker build -f docker/Dockerfile -t bespoken/bst-dev:$CIRCLE_TAG . |
There was a problem hiding this comment.
I would keep the image name the same (bespoken/bst) - and use the tag to differentiate it (bst-dev-x or bst-server-dev-x). If you look in DockerHub, that is a cleaner way to organize images.
jkelvie
approved these changes
Dec 21, 2017
|
Changes Unknown when pulling c4a9ef8 on bstDevServer into ** on master**. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.