Skip to content
This repository has been archived by the owner on Feb 7, 2024. It is now read-only.

Batch messages #64

Merged
merged 16 commits into from Feb 23, 2018
Merged

Batch messages #64

merged 16 commits into from Feb 23, 2018

Conversation

jkelvie
Copy link
Member

@jkelvie jkelvie commented Feb 21, 2018

  • Calls batch messaging endpoint
  • Uses nock for mocking virtual device calls instead of sinon
  • Supports batch or serial mode
  • Test against real batch endpoint

Added batchMessage endpoint
Switched from sinon to nock for message mocks
* Updated docs

Added TOC
Added best practices
Added comments

* More updates to docs

Fix bad links

* Trying out yaml highlighting

* use YAML highlighint throughout
Fixed issue with env variables and tokens
Added test for utf-8 characters
Force mocked pretty printer
@chris-ramon
Copy link
Contributor

lgtm 👍

@codecov
Copy link

codecov bot commented Feb 23, 2018

Codecov Report

❗ No coverage uploaded for pull request base (master@1aeb38a). Click here to learn what that means.
The diff coverage is 95.08%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #64   +/-   ##
=========================================
  Coverage          ?   92.92%           
=========================================
  Files             ?        8           
  Lines             ?      650           
  Branches          ?      119           
=========================================
  Hits              ?      604           
  Misses            ?       46           
  Partials          ?        0
Impacted Files Coverage Δ
src/BatchValidator.ts 100% <100%> (ø)
src/SequencedValidator.ts 100% <100%> (ø)
src/VirtualDeviceScript.ts 96.03% <100%> (ø)
src/VirtualDevice.ts 91.02% <89.13%> (ø)
src/VirtualDeviceValidator.ts 85.6% <94.11%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1aeb38a...69090d0. Read the comment docs.

@jkelvie jkelvie merged commit 7e14fab into master Feb 23, 2018
@jkelvie jkelvie deleted the BatchMessages branch February 23, 2018 23:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants