Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed bower dependency #10

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Removed bower dependency #10

wants to merge 2 commits into from

Conversation

AStoker
Copy link

@AStoker AStoker commented Nov 18, 2015

removed unneeded bower dependency.
#8

removed unneeded bower dependency.
bessdsv#8
@jonhunter1977
Copy link

+1

2 similar comments
@jamesmorgan
Copy link

👍

@jamlen
Copy link

jamlen commented Nov 24, 2015

👍

@julkue
Copy link

julkue commented Dec 11, 2015

It is sad that I need to give a 👍 for an issue thas is known for almost a year.

@julkue
Copy link

julkue commented Dec 14, 2015

@bessdsv If you aren't able to merge this important PR and fix issues, could you please consider to add some contributors to do so?

@bessdsv
Copy link
Owner

bessdsv commented Dec 19, 2015

I use those dependencies for installing last versions of internal libraries (jquery & jasmine-jquery) and make some magic.
And i use github fork project because contributor of bower-installer project can't merge my pull request or other pull request with one feature what i need.
I can delete dependencies but after that all people, who use this library, must upgrade libraries manually. or i must make new commits with new libraries' versions. do you have some ideas?

@AStoker
Copy link
Author

AStoker commented Dec 19, 2015

You don't need to bring in Bower as a dependency. If you list the dependencies you need (such as jQuery and jasmine-jquery) in the package config (as well as the bower.json), then if you're pulling the library down with bower, jspm, or whatever, it should pull down any needed dependencies. And from what you're telling me, it sounds like you use bower as a dev-dependency, so in that case it definitely shouldn't be included. What goes out the the end use should only be what's needed for the actual project, ideally.

@AStoker
Copy link
Author

AStoker commented Jan 12, 2016

Bump

@hansogj
Copy link

hansogj commented Apr 8, 2016

Totally agree with @AStoker . Would be nice to get rid of bower; and then allso the custom install-script of this, otherwise, well working plugin

@AStoker
Copy link
Author

AStoker commented Apr 19, 2016

@bessdsv, any update? Is there any new development on this repo?

@julkue
Copy link

julkue commented Apr 19, 2016

@AStoker if @bessdsv does not reply within 7 days, could you please fork this repository and fix that issue?

@AStoker
Copy link
Author

AStoker commented Apr 19, 2016

@julmot, can do

@AStoker
Copy link
Author

AStoker commented Apr 27, 2016

@julmot patch-1 branch of the fork has been merged with the master, and a release has been made. https://github.com/AStoker/karma-jasmine-jquery/
Registered under the name karma-jasmine-jquery-2 to avoid naming conflicts with the original (unfortunately). But you can download with with jspm, npm, or bower.

@AStoker
Copy link
Author

AStoker commented May 3, 2016

@bessdsv if this ever get's merged in, I'll mark the branch I created as deprecated (but leave it up) and point it back to the master.

@julkue
Copy link

julkue commented May 31, 2016

@bessdsv Take care of this issue.

@julkue
Copy link

julkue commented May 31, 2016

@bessdsv Please also specify where exactly you need that bower dependency. I searched your code for any bower call unsuccessfully.

@AStoker
Copy link
Author

AStoker commented Aug 18, 2016

bump

@djskinner
Copy link

Thanks @AStoker. I'm reviving an old project and this package was causing npm install to fail for me. Moving to karma-jasmine-jquery-2 fixed it right away.

@pvdlg
Copy link

pvdlg commented Jul 15, 2017

If anyone's interested I published karma-jasmine-jquery. The package has no dependencies and let you choose your version of jasmine-core karma-jasmine jasmine-jquery.

@serbanghita
Copy link

You don't have to move anything, just fork, make the change and adapt your package.json.
Here is how I fixed the dependency problem (after I made the changes):

"karma-jasmine-jquery": "git@github.com:serbanghita/karma-jasmine-jquery.git#master",

@ashvin777
Copy link

@bessdsv , can you merge either this PR or #16. There is a lot of npm audit error due to use of the older version of bower in dependencies. Below is the npm audit report -

found 29 vulnerabilities (7 low, 17 moderate, 4 high, 1 critical) in 30478 scanned packages
  29 vulnerabilities require manual review. See the full report for details.

Full Report -
report.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet