Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make BuildCommon.pm compatible with latest perl #171

Merged
merged 1 commit into from
Jun 6, 2023

Conversation

Leont
Copy link
Contributor

@Leont Leont commented Jun 6, 2023

It was previously using an experimental feature that has since been dropped. This removes the use of that feature.

This fixes #170

It was previously using an experimental feature that has since been dropped.
This removes the use of that feature.
@besser82
Copy link
Owner

besser82 commented Jun 6, 2023

Thank you for your contribution! I will merge on cli as soon as all tests are finished.

@codecov
Copy link

codecov bot commented Jun 6, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.02 ⚠️

Comparison is base (e2788e5) 89.89% compared to head (ce562f4) 89.88%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop     #171      +/-   ##
===========================================
- Coverage    89.89%   89.88%   -0.02%     
===========================================
  Files           32       32              
  Lines         3632     3628       -4     
  Branches       690      689       -1     
===========================================
- Hits          3265     3261       -4     
  Misses         227      227              
  Partials       140      140              

see 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@besser82 besser82 merged commit ce562f4 into besser82:develop Jun 6, 2023
72 of 83 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fails to configure with Perl 5.38.0(-RC0)
2 participants