Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Update LTO support status in README.md #176

Closed
wants to merge 1 commit into from

Conversation

xry111
Copy link

@xry111 xry111 commented Oct 7, 2023

No description provided.

@zackw zackw marked this pull request as draft March 26, 2024 18:56
@zackw
Copy link
Collaborator

zackw commented Mar 26, 2024

With the text as is, it would not be correct to merge this patch until after #109 is merged. The necessary compiler support now exists, but libxcrypt must also be changed to use that support before we can say "LTO is supported".

@xry111 If you would like to revise your change so that it accurately summarizes the present state of affairs (see #24 as well as #109), then I'll consider merging it.

@xry111
Copy link
Author

xry111 commented Mar 26, 2024

With the text as is, it would not be correct to merge this patch until after #109 is merged. The necessary compiler support now exists, but libxcrypt must also be changed to use that support before we can say "LTO is supported".

@xry111 If you would like to revise your change so that it accurately summarizes the present state of affairs (see #24 as well as #109), then I'll consider merging it.

We are already using that support since 38f7f06, AFAIK. But #109 already contains the wanted README.md change so I'll close this.

@xry111 xry111 closed this Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants