configure: Only text the makecontext signature we need #178
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The test/explicit-bzero.c test uses a start routine without any arguments. There is no need for the multi-argument version. This avoids a build failure with glibc and future compilers. The GNU C library declares the makecontext callback of type void (*) (void), so no cast is needed. On other systems, the type may be the (currently distinct) type void (*) (), but given that this only affects the ability to execute a test, no further machinery is added here to detect that different type.
|
There's a typo in the commit message ("Only text …" instead of "Only test …"). Maybe whoever ends up merging this can amend the commit and fix that before merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
test/explicit-bzero.ctest uses a start routine without any arguments. There is no need for the multi-argument version.This avoids a build failure with glibc and future compilers. The GNU C library declares the
makecontextcallback of typevoid (*) (void), so no cast is needed. On other systems, the type may be the (currently distinct) typevoid (*) (), but given that this only affects the ability to execute a test, no further machinery is added here to detect that different type.Related to: