Man page edits #185
Open
Man page edits #185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This also fixes #29 |
|
@vt-alt You might want to review my edits of the |
|
@solardiz LGTM |
|
I have not had time to look at these changes at all. Please be patient. |
Previously, we mixed "invalid hash" and "invalid hashed passphrase".
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is motivated by the criticism in https://www.openwall.com/lists/yescrypt/2024/03/21/1 that our wording "CPU time cost" was misleading, given that with memory-hard methods it also affects memory usage. That's addressed in the first commit here. The second commit is based on my proof-reading of the entire
crypt.5.Not yet changed here, but something we might also want to change, is renaming of the
countparameter tocost. Perhaps not only in man pages, but also in code.Edit: This also fixes #29