Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Week 3 - Add a drop down menu to set the number of comments to display #7

Merged
merged 2 commits into from Jul 22, 2020
Merged

Week 3 - Add a drop down menu to set the number of comments to display #7

merged 2 commits into from Jul 22, 2020

Conversation

bessmarche
Copy link
Owner

  • Use a select element to implement the drop down menu
  • Add fetchdata() to script.js to be executed every time a selection is made on the drop down.
  • fetchdata() gets the value selected for the number of comments, and inputs it in the request via fetch('/data?numberChoice='+n_comments) (not the prettiest way but it works)

@bessmarche bessmarche changed the title Add a drop down menu to set the number of comments to display Week 3 - Add a drop down menu to set the number of comments to display Jul 21, 2020
jtangelder
jtangelder approved these changes Jul 22, 2020
View reviewed changes
portfolio/src/main/webapp/index.html Outdated Show resolved Hide resolved
portfolio/src/main/webapp/script.js Show resolved Hide resolved
portfolio/src/main/webapp/script.js Outdated Show resolved Hide resolved
@bessmarche bessmarche changed the base branch from featureDatabase to master July 22, 2020 16:00
@bessmarche bessmarche merged commit 53ea269 into master Jul 22, 2020
@bessmarche bessmarche deleted the featureNumberofComm branch July 22, 2020 16:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtangelder jtangelder jtangelder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bessmarche @jtangelder