Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

if annotation_len > 7: #20

Closed
abcdenis opened this issue Jul 11, 2022 · 0 comments · Fixed by #21
Closed

if annotation_len > 7: #20

abcdenis opened this issue Jul 11, 2022 · 0 comments · Fixed by #21
Labels
bug Something isn't working

Comments

@abcdenis
Copy link

annotation_len compares with constant 7 and not max_annotation_len :(
But max_annotation_len is used in error message formatting.

https://github.com/best-doctor/flake8-annotations-complexity/blob/master/flake8_annotations_complexity/ast_helpers.py#L65
@abcdenis abcdenis added the bug Something isn't working label Jul 11, 2022
michael-k added a commit to michael-k/flake8-annotations-complexity that referenced this issue Nov 4, 2022
@michael-k
Check against max annotations length, not 7
62c62d5 
Fixes best-doctor#20
@michael-k michael-k mentioned this issue Nov 4, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Check against max annotations length, not 7 michael-k/flake8-annotations-complexity
1 participant
@abcdenis