Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use latest R {precommit} version #39

Merged
merged 1 commit into from
Jul 19, 2021

Conversation

lorenzwalthert
Copy link
Contributor

@lorenzwalthert lorenzwalthert commented Jul 15, 2021

This prepares for a transition to virtual environments with language: r (https://github.com/lorenzwalthert/precommit/blob/master/NEWS.md)

Summary

I think it's best to use the up-to-date revision for R pre-commit hooks. I hope you have CI/CD to check if this works.

Disclosure: I am the maintainer of the R package precommit.

Checklists

This pull/merge request meets the following requirements:

Comments have been added below around the incomplete checks.

This prepares for a transition to virtual environments with `language: r` (https://github.com/lorenzwalthert/precommit/blob/master/NEWS.md)
@ESKYoung
Copy link
Collaborator

Thanks for the contribution @lorenzwalthert! Much appreciated.

I'll find some time to review early next week - the broken checks are due to a bug in the GitHub Actions workflow, so I'll fix those in a separate PR!

@ESKYoung ESKYoung self-requested a review July 15, 2021 15:52
Copy link
Collaborator

@ESKYoung ESKYoung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @lorenzwalthert for the contribution - I've tested this locally using some of the test cases from your repo, and it looks good. Hooks trip as expected (with some minor fixes on our end - will raise a separate issue). I've also checked that all the GitHub Actions would have passed if it wasn't for issue #40, which they do.

Approving and merging into main.

@ESKYoung ESKYoung merged commit 739973e into best-practice-and-impact:main Jul 19, 2021
@lorenzwalthert lorenzwalthert deleted the patch-1 branch July 20, 2021 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants