Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update deployment and instructions #193

Merged
merged 2 commits into from
Jul 17, 2024
Merged

update deployment and instructions #193

merged 2 commits into from
Jul 17, 2024

Conversation

gisellerosetta
Copy link
Contributor

@gisellerosetta gisellerosetta commented Jul 8, 2024 •
edited
Loading

Updated the deployment and instructions to reflect that bump2version is depreciated and we're moving to bump-my-version.

@gisellerosetta gisellerosetta self-assigned this Jul 8, 2024
@sarahcollyer sarahcollyer linked an issue Jul 8, 2024 that may be closed by this pull request
Update to bump-my-version for deployment #192
Closed
rowanhemsi
rowanhemsi requested changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tried following the instructions in the readme to check it works and I'm afraid I'm getting the error saying the specified version (2023.4) does not match the last tagged version (2023.2) again

rowanhemsi
rowanhemsi approved these changes Jul 12, 2024
View reviewed changes
Copy link
Contributor

@rowanhemsi rowanhemsi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested the versioning with the updated current version number and as far as I can tell, the changes replace all instances of the old version number when bumping year or build.
Happy to approve 😄

@sarahcollyer sarahcollyer merged commit 2990c06 into main Jul 17, 2024
1 check passed
@sarahcollyer sarahcollyer deleted the move-to-bump-my-version branch July 17, 2024 15:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rowanhemsi rowanhemsi rowanhemsi approved these changes

Assignees

@gisellerosetta gisellerosetta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update to bump-my-version for deployment
3 participants
@gisellerosetta @rowanhemsi @sarahcollyer