Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ES6 String.prototype.startsWith polyfill #24

Merged
merged 2 commits into from Apr 14, 2016
Merged

Add ES6 String.prototype.startsWith polyfill #24

merged 2 commits into from Apr 14, 2016

Conversation

markwaddle
Copy link
Contributor

Older JS engines, such as the one with Node v0.12.2, throw an exception that .startsWith is undefined. Including this polyfill fixes the problem.

I opted to include this minimal polyfill instead of the full babel-polyfill in an attempt to keep in line with the minimalist style of this project.

This is a follow-up to the failed PR #23

@markwaddle
Copy link
Contributor Author

Oddly the require with string.prototype.startsWith worked with npm test locally. Hopefully this change will fix it in CI.

@bestander bestander merged commit e77a7f1 into bestander:master Apr 14, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants