Added logic to deduplicate subscriptions #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should be rebased on master |
polachok
requested changes
Nov 1, 2021
polachok
reviewed
Nov 2, 2021
polachok
reviewed
Nov 9, 2021
polachok
reviewed
Nov 10, 2021
polachok
reviewed
Nov 10, 2021
polachok
approved these changes
Nov 10, 2021
found, and web socket connection is estabilished, then check whether we have a corresponding active websocket subscription for that subscription+commitment pair
Renamed websocket connection status field for AccountUpdateManager Restored websocket disconnected uncacheable reason Replaced get_idx_by_key by get_addr_by_key
This update adds new behaviour for two cases: 1. Program account subscription exists, and a new request for one of child accounts arrive, in this case as long as parent subscription is active, no new subscription for its child account will be created 2. If account subscription exists, and then getProgramAccount request for the parent of given account arrives, before estabilishing a new subscription for it, subscriptions for it's children will be cancelled
polachok
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.