Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests #18

Open
bestguy opened this issue Aug 7, 2019 · 7 comments
Open

Add tests #18

bestguy opened this issue Aug 7, 2019 · 7 comments
Assignees

Comments

@bestguy
Copy link
Owner

bestguy commented Aug 7, 2019

Haven't kept up with Svelte testing best practices, but this project needs unit tests..

Perhaps try out https://github.com/bahmutov/cypress-svelte-unit-test

@bestguy
Copy link
Owner Author

bestguy commented Aug 15, 2019

Taking a look at: https://github.com/testing-library/svelte-testing-library

Looks promising.

@bestguy
Copy link
Owner Author

bestguy commented Aug 16, 2019

WIP: #35

@bestguy bestguy self-assigned this Aug 16, 2019
@bestguy
Copy link
Owner Author

bestguy commented Aug 20, 2019

Also: #37

@bestguy
Copy link
Owner Author

bestguy commented Sep 5, 2019

Tests have been started and merged, will update this issue with missing component tests.

@DaniAcu
Copy link
Contributor

DaniAcu commented Sep 3, 2021

I'm new here, but I'm really happy to contribute. I'd like to know if we could change the folders a little bit. I mean currently we have a __test__ folder with all our test. But I wondering if we could move more to a component folders with test and inplamentation in the same folder.

  • src
    • Alert
      • Alert.svelte
      • Alert.spec.js
    • Button
      • Button.svelte
      • Button.spec.js

I think this could help to everyone to identify quickly which components has or not test, and if they need to add it 😄

@bestguy
Copy link
Owner Author

bestguy commented Sep 5, 2021

Hi @DaniAcu , thanks for the help. The tests thing is a jest standard, so ran with it. Might be better to stick with it since there are already .d.ts files too. Might be a little much 😅

@DaniAcu
Copy link
Contributor

DaniAcu commented Sep 5, 2021

Mmm okay, yeah move all sounds too much work to do. Maybe we could just keep it in the eyes but as long as this can scale and be easy to maintain, I'm fine with that. Thanks for the feedback 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants