Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add spread props #40

Merged
merged 6 commits into from
Sep 5, 2019
Merged

Add spread props #40

merged 6 commits into from
Sep 5, 2019

Conversation

bestguy
Copy link
Owner

@bestguy bestguy commented Aug 20, 2019

Adds spread props to all components. There are a ton of HTML element attributes that we need to support, but is unfeasible to define and export every single one in each component.
This PR should address that.

@bestguy bestguy mentioned this pull request Aug 20, 2019
@bestguy
Copy link
Owner Author

bestguy commented Sep 2, 2019

Status update is { ...$$props } approach seem to work, but want to confirm unwanted props are not being passed to DOM elements before merging.

@bestguy bestguy merged commit e8056c9 into master Sep 5, 2019
@bestguy bestguy deleted the supportSpreadProps branch September 5, 2019 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant