Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: upgrade to storybook 7 #565

Merged
merged 1 commit into from
Oct 16, 2023
Merged

Conversation

benmccann
Copy link
Contributor

No description provided.

@benmccann
Copy link
Contributor Author

@bestguy @gary-mycase any chance you might be able to take a look at this one?

@bestguy
Copy link
Owner

bestguy commented Oct 13, 2023

Sure, I'll take a look to review/merge this weekend, thanks for your patience.

@kefahi
Copy link

kefahi commented Oct 15, 2023

Thanks!
I tried upgrading as outlined above, but couldn't successfully run storybook.
What are the specific steps I need to follow to get the docs folder regenerated with the new version?

@benmccann
Copy link
Contributor Author

@kefahi can you share what command you ran and what you expected to happen?

@kefahi
Copy link

kefahi commented Oct 15, 2023

I think this was my bad. The storybook binary itself was missing, hence running npm run docs/start fails. storybook package that provides the storybook binary was not mentioned in the packages.json file.
I made further tuning to make storybook7 work properly.

Can be found on this git branch.

The above branch is based on the Svelte4 fixes branch that was prepared earlier.

I'm good now with both Svelte4 and Storybook7 without any known issues (including passing CI checks).

Copy link
Owner

@bestguy bestguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @benmccann , this is great, thanks.
Looks like one change is needed in my testing.

"@storybook/blocks": "^7.2.1",
"@storybook/svelte": "^7.2.1",
"@storybook/svelte-webpack5": "^7.2.1",
"@storybook/testing-library": "^0.2.0",
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using node 20.8.1, I also needed to add:
"@storybook/theming": "^7.4.6",

otherwise got an error running npm start after npm install

Copy link
Owner

@bestguy bestguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually, I can easily do a follow on PR to add that missing dep after merge.

@bestguy bestguy merged commit d25862f into bestguy:master Oct 16, 2023
@bestguy
Copy link
Owner

bestguy commented Oct 16, 2023

Fixed with #576
Thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants