Fetch links and reviews by project #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Click here if you want to create eslint's auto-correct Pull Request See the documentation if you want to get more information about auto-correct. |
michaelrambeau
commented
Jul 17, 2017
| goToList(project, key, history) | ||
| msgbox(`Your ${settings[key].label} has been updated.`) | ||
| }) | ||
| .catch(err => { | ||
| console.error(err) |
There was a problem hiding this comment.
[eslint]
- Warning - Unexpected console statement. (no-console)
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GOAL
Load links and reviews related to projects when project pages are loaded.
Note: this feature lets logged-in users create links and reviews about projects stored in BestOfJS application but this feature is not really popular.
BEFORE
All links and all reviews were loaded when the application starts.
Problems:
AFTER
We don't load anymore all links and all reviews. Instead we load load only links and reviews related to a given project.
A new project called
bestofjs-apihas been created to serve the content.